feat(server): support multi ingress gateway mode#161
Open
Pangjiping wants to merge 5 commits intoalibaba:mainfrom
Open
feat(server): support multi ingress gateway mode#161Pangjiping wants to merge 5 commits intoalibaba:mainfrom
Pangjiping wants to merge 5 commits intoalibaba:mainfrom
Conversation
6b574f9 to
ddaf379
Compare
9635441 to
40fba82
Compare
40fba82 to
b032495
Compare
0c46993 to
ff15bda
Compare
Collaborator
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff15bdaaf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ingress exposure (direct | gateway)
mode=direct: default; required whenruntime.type=docker(client ↔ sandbox direct reachability, no L7 gateway).mode=gateway: configure external ingress.gateway.address: wildcard domain required whengateway.route.mode=wildcard; otherwise must be domain, IP, or IP:port. Do not include scheme; clients decide http/https.-
gateway.route.mode:wildcard(host-based wildcard),uri(path-prefix).headeris not yet supported.wildcard:<sandbox-id>-<port>.example.com/path/to/requesturi:10.0.0.1:8000/<sandbox-id>/<port>/path/to/requestTesting
Breaking Changes
Checklist