Adding C# to the build system (using the Mono toolchain) #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2023
|
Right... @ntindle or @ShadowMitia, do I need to separate the Docker stuff from the SCons stuff for the build to pass? |
|
Docker should probably go in first. I can't remember the exact repo ci we used but if we did it right, it won't use the dockerfile you provide here but the one on the base branch |
|
FYI: for dotnet you can use this as reference: SebLague/Chess-Challenge#3 |
|
There we go, everything builds :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to add C# to our build system, making sure we have a common ground.
I see we have the dotnet sdk, but I could not find the command to compile using it, don't hesitate to close this PR if you give me the proper way.
Because I used Mono, there were a few changes in two files, as Mono doesn't allow functions inside functions, apparently.
This follows from #1011, but might need to be merged before.