fix: Package updates and fix flows with new versions#60
Conversation
Signed-off-by: ehanoc <ehanoc@protonmail>
Deploying liquid-auth with
|
| Latest commit: |
278c91a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c21f7381.liquid-auth.pages.dev |
| Branch Preview URL: | https://chore-pkg-updates.liquid-auth.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR updates npm package dependencies to their latest versions and implements necessary code changes to maintain compatibility with the new versions. The changes address breaking API changes in major version bumps including Sentry v10, mongoose v9, ua-parser-js v2, and @simplewebauthn/server v13.
Key Changes
- Updated Sentry SDK from v7 to v10 with new integration API (
nodeProfilingIntegration()replacingProfilingIntegrationclass) - Updated test assertions from deprecated
toThrowErrorto standardtoThrowmethod - Modified UAParser import from default to named export for v2 compatibility
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/signals/signals.gateway.spec.ts | Updated test assertion method from toThrowError to toThrow |
| src/main.ts | Migrated Sentry integration to v10 API, removing HTTP tracing (now automatic) and updating profiling integration |
| src/auth/auth.service.ts | Removed FilterQuery type import and annotation from search method |
| src/assertion/assertion.service.ts | Added explicit Uint8Array wrapper for publicKey to satisfy @simplewebauthn/server v13 type requirements |
| src/app.service.ts | Changed UAParser from default import to named import for v2 compatibility |
| package.json | Updated 32 dependencies and 22 devDependencies to latest versions, including major version bumps for Sentry, mongoose, algosdk, connect-mongo, redis, and ua-parser-js |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: ehanoc <ehanoc@protonmail>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| new Sentry.Integrations.Http({ tracing: true }), | ||
| new ProfilingIntegration(), | ||
| ], | ||
| integrations: [nodeProfilingIntegration()], |
There was a problem hiding this comment.
The HTTP tracing integration has been removed during the Sentry upgrade. In the previous version, new Sentry.Integrations.Http({ tracing: true }) was included to enable HTTP calls tracing. With Sentry v10, HTTP tracing should be automatically enabled, but if you need to customize it, you should use httpIntegration() from '@sentry/node'. Verify that HTTP tracing is working as expected after this change, or explicitly add the integration if needed.
What