Skip to content

fix: resolve silent failures in 'algokit project deploy' by improving error logging #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tusharkhadde wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix: resolve silent failures in 'algokit project deploy' by improving error logging #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/algokit/cli/project/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ def _execute_deploy_command( # noqa: PLR0913
) from ex
else:
if result.exit_code != 0:
header = " deploy command output: ".center(80, "·")
logger.error(f"\n{header}\n{result.output}")
raise click.ClickException(f"Deployment command exited with error code = {result.exit_code}")


Expand Down
1 change: 1 addition & 0 deletions src/algokit/core/proc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def run( # noqa: PLR0913
env=env,
bufsize=1, # line buffering, works because text=True
encoding="utf-8",
errors="backslashreplace",
) as proc:
assert proc.stdout # type narrowing
while exit_code is None:
Expand Down