Skip to content

feat(specs): add user profile computation & amend existing user profile endpoints [PRED-3876] - #4944

Merged
shortcuts merged 6 commits into
mainfrom
feat/realtime-perso-specs
Jun 13, 2025
Merged

shortcuts merged 6 commits into
mainfrom
feat/realtime-perso-specs

Conversation

@bengreenbank

@bengreenbank bengreenbank commented Jun 6, 2025 •

Copy link
Copy Markdown
Contributor

🧭 What and Why

🎟 JIRA Ticket: PRED-3876

See RFC

Changes included:

  • Add the new endpoint described in the linked RFC
  • Amend the existing endpoint as described in the RFC

🧪 Test

n/a

@bengreenbank bengreenbank changed the title feat(specs): add user profile computation endpoint & amend existing user profile endpoint [PRED-3876] feat(specs): add user profile computation & amend existing user profile endpoints [PRED-3876] Jun 6, 2025
@algolia-bot

algolia-bot commented Jun 6, 2025 •

Copy link
Copy Markdown
Contributor

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1762
javascript 1679
php 1519
csharp 1279
java 1109
python 1086
swift 821
ruby 818
scala 23

@bengreenbank
bengreenbank marked this pull request as ready for review June 6, 2025 15:28
@bengreenbank
bengreenbank requested a review from a team as a code owner June 6, 2025 15:28
shortcuts
shortcuts previously approved these changes Jun 10, 2025

@shortcuts shortcuts left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

let me know when I can merge :)

shortcuts
shortcuts previously approved these changes Jun 12, 2025
@raed667

raed667 commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Should we merge realtime-personalization client into personalization?

The fact that it is "real-time" is just a technical detail and not a different product.

@bengreenbank

bengreenbank commented Jun 13, 2025 •

Copy link
Copy Markdown
Contributor Author

Should we merge realtime-personalization client into personalization?

The fact that it is "real-time" is just a technical detail and not a different product.

I'm not sure we can, since the base URLs are different.

@shortcuts can we/should we support different base URLs within the same spec?

@shortcuts

Copy link
Copy Markdown
Member

Should we merge realtime-personalization client into personalization?
The fact that it is "real-time" is just a technical detail and not a different product.

I'm not sure we can, since the base URLs are different.

@shortcuts can we/should we support different base URLs within the same spec?

Indeed that's not possible and wouldn't follow the open api specification, as we would have to do the matching logic ourselves to assign the correct path to the base URL

@shortcuts
shortcuts enabled auto-merge (squash) June 13, 2025 09:47
@shortcuts
shortcuts merged commit fed9be0 into main Jun 13, 2025
@shortcuts
shortcuts deleted the feat/realtime-perso-specs branch June 13, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants