Open
Conversation
Move calendar state management (route data init, query param sync, rangeChange handling) into a dedicated CalendarStateComponent, leaving MainComponent as a thin layout shell (sidebar, mobile detection, swipe). - New CalendarStateComponent owns visibleDate, calendarDateFrom/To, calendar selection, and calls mainService.refreshCalendar() on change - MainComponent retains: isMobile detection, swipe, sidebar toggle, busy-state subscriptions, and statement import trigger - Sidebar calendarChange now calls mainService.refreshCalendar() directly Co-Authored-By: Paperclip <noreply@paperclip.ing>
… actions EXP-10: Separates four mixed concerns into focused components. - CalendarListDisplayComponent: pure display, renders calendar list with per-item radio, name, balance, and icon; emits events for calendarSelect, makeDefault, editCalendar, deleteCalendar — no API calls - CalendarListActionsComponent: owns CRUD dialog lifecycle (create, edit, delete) and the \"Add a calendar\" button; emits calendarsChange after mutations - CalendarSidebarListComponent: thin container; handles makeDefault via UserApiService, wires display events to actions component - Removes StatementImportService from this component hierarchy entirely Co-Authored-By: Paperclip <noreply@paperclip.ing>
…report EXP-11: Removes the shared abstract base class and gives each report component its own typed fetch method, eliminating any-typed callbacks and unsafe string-keyed API dispatch. - DailyExpensesComponent: fetches via reportsApiService.dailyExpenses(), typed to ExpenseReportResponse - MonthlyExpensesComponent: fetches via reportsApiService.monthlyExpenses(), typed to ExpenseReportResponse - CategoryExpensesComponent: fetches via reportsApiService.categoryExpenses(), typed to CategoryExpenseReportResponse - Each component owns isBusy, dateRange, fetchSubscription, and preparedToFetch() locally - AbstractReportComponent deleted Co-Authored-By: Paperclip <noreply@paperclip.ing>
EXP-12: Replaces direct MainService reads with @input() props so the component can be reused and tested in isolation. - Add @input() calendar and @input() visibleDate to ExpenseReportComponent - Remove MainService injection; fetch logic moves to private fetchReport() - Add ngOnChanges to re-fetch when calendar or visibleDate inputs change - HeaderCalendarInfoComponent: switch from component-class popover to template-ref popover, passing calendar and visibleDate as inputs; add @input() visibleDate - header.component.html: pass [visibleDate] to app-header-calendar-info Co-Authored-By: Paperclip <noreply@paperclip.ing>
EXP-13: Replaces 4 callback @input() props with a single typed ExpenseDialogResult close value so callers use one .onClose.subscribe(). - Add ExpenseDialogResult interface: { expense?: Expense; deleted?: boolean } - ExpenseComponent, BalanceComponent: remove @input() onSubmit/onDelete; close dialog with { expense } on save, { deleted: true } on delete - TransferComponent: close with {} (saved, no specific expense returned) - Remove onExpenseSubmit/onExpenseDelete/onBalanceSubmit/onBalanceDelete from ExpenseDialogComponent and its template - CalendarService: subscribe as ExpenseDialogResult; truthiness check unchanged - StatementReviewDialogComponent: remove onExpenseDelete context callback; handle delete vs save branches via result.deleted / result.expense Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.