Add jakarta to UnusedImportRefactor#137
Conversation
| .sorted(Comparator | ||
| .comparing((ImportDeclaration i) -> ! AstraUtils.getPackageName(i.getName().toString()).startsWith(JAVA)) | ||
| .thenComparing(i -> ! AstraUtils.getPackageName(i.getName().toString()).startsWith(JAVAX)) | ||
| .thenComparing(i -> ! AstraUtils.getPackageName(i.getName().toString()).startsWith(JAKARTA)) |
There was a problem hiding this comment.
Looks good - but could we add a test for this?
There was a problem hiding this comment.
We don't have a dependency which provides any of the javax or jakarta classes, so I can either add additional test dependencies, or create a package structure in the test code using this naming convention. Any preference?
There was a problem hiding this comment.
Test scoped dependencies would be fine 👍
There was a problem hiding this comment.
@belalj73 items like javax.annotation.processing.Processor and javax.crypto.Cipher are part of the jdk and so don't need any dependencies (and won't be changing to jakarta).
There was a problem hiding this comment.
Thanks for the suggestion @harrisric. I have updated the PR accordingly.
Add line separators for these imports.
3 participants
No description provided.