Include test dependency in Mojo classpath#135
Merged
RadikalJin merged 2 commits intoalfasoftware:mainfrom Apr 2, 2025
Conversation
added 2 commits
April 2, 2025 11:35
…-plugin-classloader-does-not-include-test-dependencies
Member
|
Merged this now - thank you for your contribution to Astra, @therealluigi-gh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maven apparently only passes the source classpath entries from the module a plugin is operating on to the plugin classloader.
These changes ensure that we augment the classloader used by the
astra-maven-pluginwith the test dependencies of the module it is operating on. They also ensure that we also augmentAstraCorewith the same entries.This has been tested using the plug-in to apply a refactoring which references types in test-scoped dependencies. Without the changes in this PR
astra-maven-pluginfails with the error reported in this issue. AugmentingAstraCoreclasspath is also required otherwise AST may not be able to resolve bindings to types in test-scoped dependencies