Skip to content

Fix: Don't crash on kick without user #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheBenji
Copy link

If you do "/KICK " and don't specify a user the server crashes

home/ben/workspace/ircd.js/lib/commands.js:123
userNames = users.split(','),
^
TypeError: Cannot call method 'split' of undefined
at Object.Commands.KICK (/home/ben/workspace/ircd.js/lib/commands.js:123:27)
at Object.Server.respondToMessage (/home/ben/workspace/ircd.js/lib/server.js:171:36)
at Object.Server.respond (/home/ben/workspace/ircd.js/lib/server.js:181:14)
at Object.Server.data (/home/ben/workspace/ircd.js/lib/server.js:320:10)
at Carrier. (/home/ben/workspace/ircd.js/lib/server.js:277:51)
at Carrier.emit (events.js:95:17)
at /home/ben/workspace/ircd.js/node_modules/carrier/lib/carrier.js:71:15
at process._tickCallback (node.js:419:13)

Doesn't happen anymore with this fix and just sends an "needs more arguments"

@sespindola
Copy link
Collaborator

Good catch, thanks for the fix.
Your patch seems to alter the indentation of several lines. Could you please clean that up?

@TheBenji
Copy link
Author

TheBenji commented Nov 4, 2014

Just seems like it.
The whole part between l137-160 is now within the "else"-block and therefore the indentation moved a little.

I (well, my editor :P) also removed the trailing whitespaces (l336 & l498).

Hope that makes sense

@orliesaurus
Copy link

Can you merge this please???? @sespindola

@Meleeman01
Copy link

lol is there a way i can participate in this? otherwise i'll gladly fork this as i've been looking for a node.js implementation of irc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants