Lab 1 #7
Open
Lab 1 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Здравствуйте.
|
alexeyr
reviewed
Apr 17, 2024
Owner
alexeyr
left a comment
alexeyr
left a comment
There was a problem hiding this comment.
По первой лабораторной всё хорошо, кроме опоздания. Ставлю 16.
| module FirstSteps | ||
| where | ||
| import Data.Word (Word8) | ||
| import GHC.Exts.Heap (GenClosure(key)) |
Owner
There was a problem hiding this comment.
Это случайность? Вроде нигде не используется.
Comment on lines
+30
to
+31
| | x == z = max x y | ||
| | otherwise = max x y |
Owner
There was a problem hiding this comment.
Здесь менять не надо, но достаточно одной ветки. Видно ли, почему?
Author
There was a problem hiding this comment.
Здравствуйте!
Ну да, понятно что первая строка лишняя и можно просто otherwise оставить
| module Lists where | ||
|
|
||
| import Data.List (delete) | ||
| import Data.Bits (Bits(xor)) |
Owner
There was a problem hiding this comment.
Это тоже похоже на случайно оставленное после редактирования (а вот delete видно, где используется).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.