Add state to callback functions - #70
Open
mattotodd wants to merge 1 commit into
Open
Conversation
add state to callback functions
Author
|
a love here? |
Collaborator
|
Sorry for the delay, we're back on track here. I think this is valuable. It would need tests and CHANGELOG to get this in. Care to do it @mattotodd? |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using this package to write node-red bindings for alexa.
The issue is that the way that node-red processes messages, it can not respond to an http request until the end of a chain of nodes, and then it uses the express response object to respond.
These nodes do not know about one another, they only pass a message (javascript object) down the chain, and the express response object needs to be passed down that chain.
HTTP In ---> Do Some Processing --> Add Alexa Say Command --> HTTP Out
The way the library was currently written, I couldn't find a way to pass along the express response object.
So for now I'm including it it my package with the changes, but I'd rather include
alexa-appas a dependencyThe usage within my project can be found here