Skip to content

fix: filter card style #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: filter card style #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
772 changes: 772 additions & 0 deletions docs/en/solutions/How_to_Install_and_use_Featureform.md
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added docs/public/180.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions styles/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,11 @@
.rp-font-bold {
font-weight: 600;
}

body {
background-color: rgb(247, 249, 252);
}

.post-list .rp-text-2xl {
font-size: 16px
}
9 changes: 5 additions & 4 deletions theme/components/Checkbox/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { forwardRef, useCallback } from "react";
import { useI18n } from "rspress/runtime";

export interface CheckboxProps {
label: string;
Expand Down Expand Up @@ -29,7 +28,7 @@ export default forwardRef<HTMLInputElement, CheckboxProps>(

return (
<label
className={`flex items-center space-x-2 cursor-pointer ${
className={`flex items-start space-x-2 cursor-pointer ${
disabled ? "opacity-50 cursor-not-allowed" : ""
} ${className}`}
>
Expand All @@ -40,7 +39,7 @@ export default forwardRef<HTMLInputElement, CheckboxProps>(
onChange={handleChange}
disabled={disabled}
className={`
w-4 h-4
w-4 h-4
rounded
border border-gray-300
bg-white
Expand All @@ -52,6 +51,8 @@ export default forwardRef<HTMLInputElement, CheckboxProps>(
transition-all
duration-200
!mr-2
!mt-1
flex-shrink-0
${disabled ? "bg-gray-100" : "hover:border-gray-400"}
${checked ? "border-blue-600 bg-blue-600" : ""}
`}
Expand All @@ -60,7 +61,7 @@ export default forwardRef<HTMLInputElement, CheckboxProps>(
{label && (
<span
className={`
text-l font-medium
text-l
${disabled ? "text-gray-500" : "text-black-700"}
transition-colors duration-200
Comment on lines +64 to 66
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix invalid Tailwind classes

  • text-l is not a valid Tailwind size (use text-base or text-lg).
  • text-black-700 is invalid; use text-gray-700 or text-neutral-700.
-              text-l
-              ${disabled ? "text-gray-500" : "text-black-700"}
+              text-base
+              ${disabled ? "text-gray-500" : "text-gray-700"}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
text-l
${disabled ? "text-gray-500" : "text-black-700"}
transition-colors duration-200
text-base
${disabled ? "text-gray-500" : "text-gray-700"}
transition-colors duration-200
🤖 Prompt for AI Agents 
In theme/components/Checkbox/index.tsx around lines 64 to 66, the class string
uses invalid Tailwind utilities ("text-l" and "text-black-700"); replace
"text-l" with a valid size (e.g., "text-base" or "text-lg") and replace
"text-black-700" with a valid color (e.g., "text-gray-700" or
"text-neutral-700"), keeping the disabled conditional logic intact so the final
class concatenation still yields the disabled color when appropriate.

`}
Expand Down
10 changes: 6 additions & 4 deletions theme/components/HomeBanner/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useI18n, usePageData } from "@rspress/runtime";
import { useI18n, usePageData, useSite } from "@rspress/runtime";

interface StyledProps {
className?: string;
Expand All @@ -10,6 +10,8 @@ interface BannerProps extends StyledProps {

export const HomeBanner: React.FC<BannerProps> = ({ className }) => {
const pageData = usePageData();
const siteData = useSite();
console.log(pageData, siteData);
const t = useI18n();

// const logo =
Expand All @@ -22,16 +24,16 @@ export const HomeBanner: React.FC<BannerProps> = ({ className }) => {
return (
<div className={className}>
<div className="max-w-3/5">
<h1 className="!text-4xl !font-bold !mb-6">
<h1 className="!text-xl !font-semibold !mb-6">
{/* {pageData.siteData.title} */}
{t("knowledge_title")}
</h1>
<p className="text-xl !font-semibold ">
<p className="">
{/* {pageData.siteData.description} */}
{t("knowledge_description")}
</p>
</div>
{/* <img width={240} src={logo}></img> */}
<img width={180} src={`${pageData.siteData.base}180.png`}></img>
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Harden base path join and add alt text

Avoid double/missing slashes and add alt for accessibility.

-      <img width={180} src={`${pageData.siteData.base}180.png`}></img>
+      <img
+        width={180}
+        alt="Knowledge logo"
+        src={`${pageData.siteData.base.replace(/\\/?$/, "/")}180.png`}
+      />
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<img width={180} src={`${pageData.siteData.base}180.png`}></img>
<img
width={180}
alt="Knowledge logo"
src={`${pageData.siteData.base.replace(/\/?$/, "/")}180.png`}
/>
🤖 Prompt for AI Agents 
In theme/components/HomeBanner/index.tsx around line 36, the img src is built by
naive string concatenation which can produce double or missing slashes
(src={`${pageData.siteData.base}180.png`}) and the img lacks an alt attribute;
update the src construction to robustly join the base path and filename (e.g.,
trim trailing slash from base or ensure exactly one slash between base and
"180.png", or use a URL/utility join function) and add a descriptive alt
attribute for accessibility (e.g., alt="Site logo" or appropriate text); also
make the img element self-closing and preserve the width prop.

</div>
);
};
4 changes: 2 additions & 2 deletions theme/components/HomeContent/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export const HomeContent: React.FC = () => {
<div className="flex-1/4 mr-6 sticky">
<Card
style={{ marginBottom: "24px" }}
title="Products"
title={<div style={{ fontSize: "16px" }} className="font-medium ">Products</div>}
content={
<>
{postProducts.map((product) => (
Expand All @@ -173,7 +173,7 @@ export const HomeContent: React.FC = () => {
></Card>
<Card
style={{ marginBottom: "24px" }}
title="Kinds"
title={<div style={{ fontSize: "16px" }} className="font-medium ">Kinds</div>}
content={
<>
{postKinds.map((kind) => (
Expand Down
4 changes: 2 additions & 2 deletions theme/components/PostList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const PostList: FC<PostListProps> = ({ postList }) => {
themeConfig?.lastUpdatedText || localesLastUpdatedText;

return (
<div>
<div className="post-list">
{notEmpty ? (
postList.map((post) => {
const { kinds, products } = post;
Expand Down Expand Up @@ -72,4 +72,4 @@ export const PostList: FC<PostListProps> = ({ postList }) => {
)}
</div>
);
};
};