Skip to content

Make easier to check if configuration should be saved#60

Open
gmag11 wants to merge 2 commits intoalanswx:masterfrom
gmag11:feature/save_config_flag
Open

Make easier to check if configuration should be saved#60
gmag11 wants to merge 2 commits intoalanswx:masterfrom
gmag11:feature/save_config_flag

Conversation

@gmag11
Copy link
Contributor

@gmag11 gmag11 commented Oct 24, 2019

This implements a flag to let user code to check if configuration has to be saved. This makes possible to work without the need of _savecallback implementation

@gmag11
Copy link
Contributor Author

gmag11 commented Oct 24, 2019

If this PR is merged together with #59 a small conflict has to be solved.

<<<<<<< HEAD
		if (!connectedDuringConfigPortal && _savecallback != NULL) {
=======
		_shouldSaveConfig = true;
		if ( _savecallback != NULL) {
>>>>>>> feature/save_config_flag

@alanswx
Copy link
Owner

alanswx commented Aug 20, 2021

do we still need this? sorry i missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants