refactor: replace string-similarity w/ fastest-levenshtein
#105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
commented
Jun 28, 2025
| const best = closest(value, VALID_TYPES); | ||
|
|
||
| if (best.rating > 0.3) { | ||
| return fixer.replaceText(sibling, `'${best.target}'`); |
There was a problem hiding this comment.
I don't know what is happening here. If I don't change this, the test fails (both on my computer and on CI).
I choose to simply change the quote style instead of modifying the test cases.
SukkaW
changed the title
string-similarity w/ fastest-levenshtein
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
string-similaritypackage is deprecated. Having this as a dependency will produce a warning during package installation.The PR replaces it with a more widely adopted and more performant package
fastest-levenshtein.