fix: provide minimal Jcode SDK runtime fixes for ohAgent - #3
Open
akvarel wants to merge 13 commits into
Open
Conversation
The recheck found the render still captured the generating repo's live ahead/behind/dirty counts, which change with every commit. Add a test-only git-info cache seed and pin the widget to a clean fixture branch. The version label is compile-time build meta and is left as is.
begin_connect returned Connected for any handle present in the pool, even when the backing child process had crashed or been killed. Every tool call on such a stale handle failed with 'Failed to send request' (writer channel closed) and reconnect was impossible without a server restart. begin_connect now checks child liveness (is_running) and drops the stale client/handle/refcount before returning Leader so a fresh process is spawned. Adds begin_connect_replaces_dead_client test. AI-assisted: Jcode
RED: attached SessionInfo drops requested working_dir while permission responses are documented as unsupported without the permissions capability.\n\nAI-assisted: Jcode
GREEN: preserve the effective create/attach working_dir through the state reply and cache it for session listings. Permission responses remain rejected because this bridge has no permissions capability or prompt source.\n\nAI-assisted: Jcode
AI-assisted: Jcode
AI-assisted: Jcode
AI-assisted: Jcode
AI-assisted: Jcode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide the minimal Jcode runtime delta required by ohAgent's public
jcode-sdkintegration.Validation
cargo test -p jcode-base mcp::pool::tests::begin_connect_replaces_dead_clientcargo test -p jcode-sdk -p jcode-harness-api-serverDelivery and safety
1jehuang/jcodepull request is createdAI-assisted: JcodeThis PR is the Jcode dependency for the ohAgent public SDK runtime migration.
Fork CI compatibility
DEPLOY_KEYis unavailablescripts/test_fork_ci_workflow.pycargo fmt --all -- --checkpasses