Dev#1
Open
amin-jabri wants to merge 7 commits intoakiyamalab:masterfrom
Open
Conversation
Add cmake modules, gitignore and clang-format files.
Fix CRLF/LF git conversion problem. Apply clang-format to source-code.
Fix header inclusion order. Remove relative path in included headers.
Comment unused parameter in UngappedExtenderGpui's member function. Clang-format all the source code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds cmake build support. Unit-tests could also be built and run. googletest is added as a submodule to this project and is built and used when compiling unit-tests. Also, duplicate header files are removed and included headers are organized. The source code base is formatted consistently using clang-format (code style is defined in .clang-format file).