chore(wallet): remove leftover self-custody e2e assertions#3200
Conversation
Follow-up to #3175. After turning off the self_custody feature flag on console-beta, three e2e specs still assert the connect-wallet button is visible and fail in CI.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThree Playwright UI test files are simplified by removing test assertions and cases that verify wallet connection prompts after deployment. The SSH key generation test now ends after key artifact validation, the SDL builder deployment test that checked wallet connection is removed, and the custom container form test flow is deleted entirely. ChangesDeployment Test Simplification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3200 +/- ##
==========================================
- Coverage 64.04% 62.60% -1.44%
==========================================
Files 1097 1014 -83
Lines 26694 24743 -1951
Branches 6483 6084 -399
==========================================
- Hits 17096 15491 -1605
+ Misses 8396 8082 -314
+ Partials 1202 1170 -32
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Why
Follow-up to #3175 (which removed the bulk of the self-custody Playwright suite). After turning off the
self_custodyfeature flag on console-beta, three e2e specs still asserted the presence of theconnect walletbutton and failed in test-beta run 26132630375.What
apps/deploy-web/tests/ui/custom-container-form.spec.ts— the entire test only asserted the connect-wallet prompt after submitting the custom-container form.apps/deploy-web/tests/ui/deploy-linux.spec.ts— drop the final "create deployment" click and connect-wallet expectation. The test still exercises template selection, distro selection, SSH key generation and the downloadedkeypair.zip.test("create deployment from SDL builder", ...)block fromapps/deploy-web/tests/ui/sdl-builder-deployment.spec.ts. The other 7 tests in the describe (preview, multi-service, YAML structure, etc.) are untouched.No page-object, fixture or app-code changes were needed —
connect walletno longer appears anywhere underapps/deploy-web/tests.The other failures in the same CI run (
passwordless-login,managed-wallet-api-keysflake,deploy-from-a-template) are not connect-wallet related and are out of scope for this PR.Test plan
Deploy Console Webworkflow on this branch; expect the three previously-failing self-custody assertions to be gone.sdl-builder-deployment.spec.tsstill pass.deploy-linux.spec.tsstill validates SSH key generation end-to-end.Summary by CodeRabbit