Skip to content

chore(wallet): remove leftover self-custody e2e assertions#3200

Merged
baktun14 merged 1 commit into
mainfrom
chore/wallet-remove-leftover-self-custody-e2e
May 20, 2026
Merged

chore(wallet): remove leftover self-custody e2e assertions#3200
baktun14 merged 1 commit into
mainfrom
chore/wallet-remove-leftover-self-custody-e2e

Conversation

@baktun14
Copy link
Copy Markdown
Contributor

@baktun14 baktun14 commented May 20, 2026

Why

Follow-up to #3175 (which removed the bulk of the self-custody Playwright suite). After turning off the self_custody feature flag on console-beta, three e2e specs still asserted the presence of the connect wallet button and failed in test-beta run 26132630375.

What

  • Delete apps/deploy-web/tests/ui/custom-container-form.spec.ts — the entire test only asserted the connect-wallet prompt after submitting the custom-container form.
  • Trim apps/deploy-web/tests/ui/deploy-linux.spec.ts — drop the final "create deployment" click and connect-wallet expectation. The test still exercises template selection, distro selection, SSH key generation and the downloaded keypair.zip.
  • Remove the test("create deployment from SDL builder", ...) block from apps/deploy-web/tests/ui/sdl-builder-deployment.spec.ts. The other 7 tests in the describe (preview, multi-service, YAML structure, etc.) are untouched.

No page-object, fixture or app-code changes were needed — connect wallet no longer appears anywhere under apps/deploy-web/tests.

The other failures in the same CI run (passwordless-login, managed-wallet-api-keys flake, deploy-from-a-template) are not connect-wallet related and are out of scope for this PR.

Test plan

  • Re-run the Deploy Console Web workflow on this branch; expect the three previously-failing self-custody assertions to be gone.
  • Confirm the remaining 7 tests in sdl-builder-deployment.spec.ts still pass.
  • Confirm deploy-linux.spec.ts still validates SSH key generation end-to-end.

Summary by CodeRabbit

  • Tests
    • Removed test cases that verified wallet connection prompts across deployment flow scenarios.

Review Change Stack

Follow-up to #3175. After turning off the self_custody feature flag on
console-beta, three e2e specs still assert the connect-wallet button is
visible and fail in CI.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 070cb16e-7828-4162-b755-685c28375161

📥 Commits

Reviewing files that changed from the base of the PR and between d29827d and f0912a3.

📒 Files selected for processing (3)
  • apps/deploy-web/tests/ui/custom-container-form.spec.ts
  • apps/deploy-web/tests/ui/deploy-linux.spec.ts
  • apps/deploy-web/tests/ui/sdl-builder-deployment.spec.ts
💤 Files with no reviewable changes (3)
  • apps/deploy-web/tests/ui/sdl-builder-deployment.spec.ts
  • apps/deploy-web/tests/ui/custom-container-form.spec.ts
  • apps/deploy-web/tests/ui/deploy-linux.spec.ts

📝 Walkthrough

Walkthrough

Three Playwright UI test files are simplified by removing test assertions and cases that verify wallet connection prompts after deployment. The SSH key generation test now ends after key artifact validation, the SDL builder deployment test that checked wallet connection is removed, and the custom container form test flow is deleted entirely.

Changes

Deployment Test Simplification

Layer / File(s) Summary
Remove wallet connection assertions from deployment tests
apps/deploy-web/tests/ui/deploy-linux.spec.ts, apps/deploy-web/tests/ui/sdl-builder-deployment.spec.ts, apps/deploy-web/tests/ui/custom-container-form.spec.ts
SSH key generation test is shortened to end after key artifact validation instead of creating a deployment and verifying wallet connection. SDL builder "create deployment" test case that asserted wallet button visibility is removed. Custom container form test that verified wallet prompt after deployment is fully removed with associated imports.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • akash-network/console#3175: Direct alignment with self-custody Playwright suite removal and wallet flow rewiring affecting the same deploy-web UI test files.

Suggested labels

size: S, experienced-contributor

Suggested reviewers

  • stalniy
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/wallet-remove-leftover-self-custody-e2e

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.60%. Comparing base (d29827d) to head (f0912a3).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
- Coverage   64.04%   62.60%   -1.44%     
==========================================
  Files        1097     1014      -83     
  Lines       26694    24743    -1951     
  Branches     6483     6084     -399     
==========================================
- Hits        17096    15491    -1605     
+ Misses       8396     8082     -314     
+ Partials     1202     1170      -32     
Flag Coverage Δ *Carryforward flag
api 84.25% <ø> (ø) Carriedforward from d29827d
deploy-web 47.45% <ø> (+<0.01%) ⬆️
log-collector ?
notifications 91.06% <ø> (ø) Carriedforward from d29827d
provider-console 81.48% <ø> (ø) Carriedforward from d29827d
provider-inventory ?
provider-proxy 86.08% <ø> (ø) Carriedforward from d29827d
tx-signer ?

*This pull request uses carry forward flags. Click here to find out more.
see 84 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: chore that does not touch source code files.

@baktun14 baktun14 added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit f5d3771 May 20, 2026
56 checks passed
@baktun14 baktun14 deleted the chore/wallet-remove-leftover-self-custody-e2e branch May 20, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant