Skip to content

DXE-5745 Reduce JSON size #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sielaq wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DXE-5745 Reduce JSON size #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions pkg/providers/clientlists/create_clientlist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,25 @@ func saveListItemsJSON(clientList *clientlists.GetClientListResponse, tfWorkPath
listItems := []clientlists.ListItemPayload{}

for _, v := range clientList.Items {
tags := []string{}
tags = append(tags, v.Tags...)

listItems = append(listItems, clientlists.ListItemPayload{
Value: v.Value,
Description: v.Description,
Tags: tags,
ExpirationDate: v.ExpirationDate,
})
item := clientlists.ListItemPayload{
Value: v.Value, // Value is always included
}

if v.Description != "" {
item.Description = v.Description
}

if len(v.Tags) > 0 {
tags := make([]string, len(v.Tags))
copy(tags, v.Tags)
item.Tags = tags
}

if v.ExpirationDate != "" {
item.ExpirationDate = v.ExpirationDate
}

listItems = append(listItems, item)
}

jsonBody, err := json.MarshalIndent(listItems, "", " ")
Expand Down
6 changes: 3 additions & 3 deletions pkg/providers/clientlists/templates/client-list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ resource "akamai_clientlist_list" "list_{{.ClientList.ListID}}" {

content {
value = items.value.value
description = items.value.description
tags = items.value.tags
expiration_date = items.value.expirationDate
description = try(items.value.description, "")
tags = try(items.value.tags, [])
expiration_date = try(items.value.expirationDate, "")
}
}
{{- end}}
Expand Down