This repository was archived by the owner on Sep 7, 2022. It is now read-only.
fix child process hanging on unclosed connections#46
Open
jkruse14 wants to merge 2 commits intoajmath:masterfrom
Open
fix child process hanging on unclosed connections#46jkruse14 wants to merge 2 commits intoajmath:masterfrom
jkruse14 wants to merge 2 commits intoajmath:masterfrom
Conversation
Author
|
I got rid of child_process and call the function directly because this allows you to set breakpoints and debug the scheduled task lambda. |
Author
|
@ajmath - what are your thoughts on this update? |
Owner
|
@jkruse14 First and foremost, thanks for the PR and apologies for not getting back to you sooner. So the behavior you're adding is actually the way this plugin worked before #22 which allows it to function with non javascript languages. I would suggest that we only try invoking the function directly when the plugin is running in a node serverless project and fallback to shelling out to support non javascript projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.