Skip to content

Improve accessibility: alert on error. #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shivbijlani
Copy link

Update gutter.js to allow assistive technology to announce an error when it occurs in a row.

Update gutter.js to allow assistive technology to announce an error when it occurs in a row.
@nightwing
Copy link
Member

Are you sure this improves accessibility? It announces errors randomly while typing and scrolling, which makes reading of the code harder.

@shivbijlani
Copy link
Author

Thanks for taking a look @nightwing . Without this, there is no way to know if what you have typed in the editor is incorrect. If you can't see the red X in the gutter, then you cant hover over it. Which means there is no way to see the error message tooltip. A better fix would be to show the error message in an element that is always visible so that the low vision user can tab to it. That is a larger design change.

The accessibility best practice for error messages that popup is to announce them with role="alert".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants