Liquid Support

[3limin4t0r]

I use the liquid editor, but needed more liquid support.

Previously liquid had one mode supporting HTML and Liquid highlighting, but this mode had no HTML/XML tag completion.

I stripped Liquid in two parts, around the same way php was done. The default Liquid mode now only support plain/text. However, I added two new modes: HTML (Liquid) & YAML (Liquid). Since I need Liquid in plain text, HTML and YAML.

I've also added some TODOs for the things I don't have time for right now, but might need attention in the future.

I've requested the CLA, but don't have a response yet. This will be attached at a later point.

[nightwing]

@3limin4t0r is there some documentation about yaml and txt liquid modes, and is the plain text version used anywhere? Changing the liquid mode like this is a breaking change which we should make only if absolutely necessary

[3limin4t0r]

@nightwing liquid is like erb or php an overlay which gets parsed before it goes through the other parser. So I don't see why the default shouldn't be text. I can change it back, so the default is html, but if people want to use it for plain text there is not really an option in that case.

[nightwing]

I've requested the CLA, but don't have a response yet. This will be attached at a later point.

What did you mean, from whom did you request the CLA?

So I don't see why the default shouldn't be text.

This depends on behavior of other text-editors, and on the way .liquid files are usually used, but i couldn't find much info about this, do you know any open source projects that have .liquid files?

but if people want to use it for plain text there is not really an option in that case.

We could support .txt.liquid for that case

[3limin4t0r]

What did you mean, from whom did you request the CLA?

We followed the corporate link on the CONTRIBUTING.md page and filled in the form. But haven't heart anything back. If needed we can submit the info a second time.

This depends on behavior of other text-editors, and on the way .liquid files are usually used, but i couldn't find much info about this, do you know any open source projects that have .liquid files?

I don't know if any open source project use it for plain/text usage. However, I may need this functionality in the future for the project I'm currently working on (although not open source). It doesn't have to be the default. So I've no problem switching back to the HTML default, since that's the most used format.

We could support .txt.liquid for that case

Would it be okay if I rewrote Liquid to default to HTML and make specific versions for text and YAML? Resulting in the modes liquid (HTML), yaml_liquid (YAML) and plain_text_liquid (plain text) instead of liquid (plain text), html_liquid (HTML) and yaml_liquid (YAML).

[xhoy]

@nightwing can this be merged??!?!?!

[nudded]

@3limin4t0r any chance you can fix the conflicts? I'm also very interested in this.

[3limin4t0r]

@nudded Not on short term. However conflicts need to be resolved anyway, since we use this version in production and are otherwise stuck with the old version of the ace editor. I'll check with my employer if I can reserve a day to resolve the conflicts somewhere in the coming few weeks.

[3limin4t0r]

@nudded I merged the PR with upstream master and should be up to date with the latest ace version (a7acb59).

[nudded]

@nightwing Any further action that needs to be taken here?