Skip to content

fix: fallback to email local part when user name is missing #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: fallback to email local part when user name is missing #912

wants to merge 1 commit into from

Conversation

@dev-whoan
Copy link

@dev-whoan dev-whoan commented Mar 24, 2025 •
edited
Loading

What issues does your PR fix?

What does your PR do?

This PR addresses an issue where Git OAuth login fails with a 'NoneType' object has no attribute 'split' error if a user’s name field is missing in user_data. Specifically:

  1. It adds a fallback mechanism to use the local part of the user’s primary email address (the portion before the @) when user_data["name"] is None or empty.
  2. It updates documentation (FAQ) to clarify how to handle missing user names during OAuth.
  3. (chore): Remove unnecessary spaces in ldap-oauth.md.

Checklist

For all Pull Requests

@dev-whoan
fix: fallback to email local part when user name is missing
f452769 
- Prevents 'NoneType' error by checking for missing user name before calling split()
- Uses primary email's local part (before '@') as first_name if user name is not provided

Signed-off-by: Eugene <[email protected]>
@stale
Copy link

stale bot commented Jun 26, 2025

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.

Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Jun 26, 2025
@stale stale bot closed this Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper thesuperzapper is a code owner

Assignees

No one assigned

Labels

lifecycle/stale lifecycle - this is stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Git OAuth invalid login: Missing user name triggers 'NoneType' error

1 participant

@dev-whoan