Skip to content

Conversation

@ryantanner
Copy link
Contributor

Description

Add inbound PR and release processes to runbook.

How was it tested? What documentation was provided?

Docs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

1. External contributor opens a pull request against `airbnb/viaduct`.
2. Viaduct maintainer reviews and approves the pull request in Github.
3. Viaduct maintainer applies the changes to Treehouse using Copybara.
- In Treehouse, run `./_infra/scripts/inbound/manual-inbound.sh <inbound-pr-number>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this integrate with yak so that you can call it with yak scripts/inbound/manual-inbound.sh?

I'm not sure what the advantage is for yak, but this seems to be the pattern that we uses for most things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants