cibuildwheel: remove useless pp* skip selector - #291
Conversation
2fbeabf to
4b998ce
Compare
Confidence Score: 5/5No blocking failure remains. No accepted blocking findings remain.
What T-Rex did
Reviews (5): Last reviewed commit: "Merge branch 'master' into remove-cibuil..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 437 437
Branches 17 17
=========================================
Hits 437 437
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FTR, in the age of ai slop, such comments make PRs look suspicious because various inauthentic mass-contribs add such statements to their templates automatically, and then you open the diff tab and there's something like "100500 lines removed, 1 line saying hello world added" 🫠 Not sure how we can deal with these better though.. Just watch out for the claims that your agent makes for you. |
c95c4a1 to
8714aa3
Compare
Since cibuildwheel 3.0.0, PyPy builds are no longer enabled by default, so the dead pp* skip selector matches a group that was never enabled, producing: Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled. Mirrors aio-libs/multidict#1283 (removes it from both pyproject.toml and the CI workflow, since the workflow-level CIBW_SKIP env var or reusable-workflow input would otherwise keep injecting it regardless of the pyproject.toml setting). Co-authored-by: Julien Stephan <31988046+justeph@users.noreply.github.com>
8714aa3 to
5a9ff6d
Compare
What do these changes do?
Removes the dead
pp*cibuildwheel skip selector. PyPy build groups have not been enabled by default since cibuildwheel 3.0, so the selector matches nothing and cibuildwheel only warns:Mirrors aio-libs/multidict#1283, removing it from both
pyproject.tomland the twowheel-tags-to-skipcall sites in.github/workflows/ci-cd.yml(each branch hadpp*appended, which fed intoCIBW_SKIPregardless of the pyproject.toml setting).Are there changes in behavior for the user?
No. Only the wheel build pipeline configuration changes, not the published wheels.
Related issue number
Related to aio-libs/multidict#1283 (does not close it).
Checklist
CHANGES/folderAgent run details (optional, for reviewers)
Verified: grepped the full working tree for
pp*after the change (no matches left), and confirmedpyproject.toml(tomllib) and.github/workflows/ci-cd.yml(PyYAML) still parse. Did not run the full test suite or docs spellcheck in the environment this was drafted in, since network access there is restricted; please confirm CI is green before marking ready.Drafted with Claude (Sonnet 5) in a Cowork session. Reviewed by @Polandia94