feat: silence ConnectionReset errors - #209
Closed
rwakulszowa wants to merge 1 commit into
Closed
Conversation
The previous implementation would print a verbose error message
whenever a session ends:
```
Traceback (most recent call last):
File ".../src/aioftp/server.py", line 1013, in dispatcher
result = task.result()
File ".../src/aioftp/server.py", line 917, in parse_command
raise ConnectionResetError
ConnectionResetError
```
It's not exactly necessary: the (default) logger prints an
informative message anyway:
> [14:44:51]: [aioftp.server] closing connection from 127.0.0.1:48034
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 97.94% 97.90% -0.05%
==========================================
Files 6 6
Lines 2094 2097 +3
==========================================
+ Hits 2051 2053 +2
- Misses 43 44 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Nevermind, it works fine when the connection is closed cleanly. My bad, wrong testing setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The previous implementation would print a verbose error message whenever a session ends:
It's not exactly necessary: the (default) logger prints an informative message anyway:
Are there changes in behavior for the user?
Less error-like logs whenever a connection ends
Checklist