feat: un-hardcode SYST response - #208
Merged
pohmelie merged 1 commit intoAug 11, 2026
Merged
Conversation
It should identify the underlying OS. Allow the caller to specify the value.
rwakulszowa
force-pushed
the
feat/modifiable-system-message
branch
from
August 10, 2026 13:23
f3b7d14 to
efa36b7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 6 6
Lines 2094 2095 +1
=======================================
+ Hits 2051 2052 +1
Misses 43 43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
I think I will merge this, but what is the reason for this? Anyone uses SYST at all? I mean... the value of SYST response |
Contributor
Author
|
Whether anyone actually cares about the result in practice - I have no idea. The only reason I implemented this was because it's a well known (albeit not too useful) command and someone might wanna use it, so I figured it's better to have it configurable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Un-hardcode SYST response
It should identify the underlying OS. Allow the caller to specify the value.
Are there changes in behavior for the user?
The SYST response is no longer hardcoded to UNIX
Checklist