Skip to content

feat: un-hardcode SYST response - #208

Merged
pohmelie merged 1 commit into
aio-libs:masterfrom
rwakulszowa:feat/modifiable-system-message
Aug 11, 2026
Merged

feat: un-hardcode SYST response#208
pohmelie merged 1 commit into
aio-libs:masterfrom
rwakulszowa:feat/modifiable-system-message

Conversation

@rwakulszowa

Copy link
Copy Markdown
Contributor

What do these changes do?

Un-hardcode SYST response
It should identify the underlying OS. Allow the caller to specify the value.

Are there changes in behavior for the user?

The SYST response is no longer hardcoded to UNIX

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

It should identify the underlying OS. Allow the caller to specify the
value.
@rwakulszowa
rwakulszowa force-pushed the feat/modifiable-system-message branch from f3b7d14 to efa36b7 Compare August 10, 2026 13:23
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.94%. Comparing base (4552c2d) to head (efa36b7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files           6        6           
  Lines        2094     2095    +1     
=======================================
+ Hits         2051     2052    +1     
  Misses         43       43           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pohmelie

Copy link
Copy Markdown
Collaborator

I think I will merge this, but what is the reason for this? Anyone uses SYST at all? I mean... the value of SYST response

@rwakulszowa

Copy link
Copy Markdown
Contributor Author

Whether anyone actually cares about the result in practice - I have no idea. The only reason I implemented this was because it's a well known (albeit not too useful) command and someone might wanna use it, so I figured it's better to have it configurable.

@pohmelie
pohmelie merged commit 35b6b83 into aio-libs:master Aug 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants