Skip to content

Conversation

@agoscinski
Copy link
Collaborator

The implementation as in aiida-core.

@agoscinski agoscinski requested a review from eimrek November 21, 2024 15:23
@edan-bainglass edan-bainglass force-pushed the nodes-statistics-endpoint branch from 14cad43 to 671f6de Compare December 2, 2025 18:04
The implementation as in aiida-core.
@edan-bainglass edan-bainglass force-pushed the nodes-statistics-endpoint branch from 671f6de to 9ea717f Compare December 2, 2025 18:05
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agoscinski. I tested this locally and found that it needs access to the DB to gather statistics. Without the with_dbenv decorator, this endpoint, if hit first, raises an error that no profile is loaded. The decorator ensures one is. I've pushed the change.

LGTM!

Copy link
Collaborator Author

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants