-
Notifications
You must be signed in to change notification settings - Fork 229
Update the computer_configure
CLI command
#6924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
edan-bainglass
wants to merge
11
commits into
aiidateam:main
Choose a base branch
from
edan-bainglass:configure-computer-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update the computer_configure
CLI command
#6924
edan-bainglass
wants to merge
11
commits into
aiidateam:main
from
edan-bainglass:configure-computer-cli
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsistency There are no additional fields. This is just a reference to the parent `Transport.Model`. Still best to follow the hierarchical chain for consistency.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6924 +/- ##
==========================================
- Coverage 79.13% 78.97% -0.15%
==========================================
Files 565 565
Lines 43391 43424 +33
==========================================
- Hits 34331 34288 -43
- Misses 9060 9136 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…`computer_configure`
187e038
to
5e431f7
Compare
Marked as draft until #6198 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6198
This PR updates the
computer_configure
CLI command w.r.t changes in #6198 (transport pydantic models).