-
Notifications
You must be signed in to change notification settings - Fork 15
Update base image to python-3.11.3 #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielhollas
wants to merge
30
commits into
main
Choose a base branch
from
python-3.10.11
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
d62a24b
Update base image to python-3.10.11
danielhollas e52ca1e
3.11.3
danielhollas 4a77ab9
Update mamba
danielhollas 4985362
Update zstandard
danielhollas 5ce75da
Install aiidalab from git
danielhollas dd63d3b
Update stack/base/Dockerfile
danielhollas 3fe3513
Install aiidalab from fork
danielhollas 01e7258
Merge branch 'main' into python-3.10.11
danielhollas 3f28b84
Bump aiidalab to 24.07.0
danielhollas fcceb68
Fix aiidalab version
danielhollas ea3e431
Merge branch 'main' into python-3.10.11
danielhollas bda137e
Merge branch 'main' into python-3.10.11
danielhollas 990d9bc
Merge branch 'main' into python-3.10.11
danielhollas 4d11db0
Merge branch 'main' into python-3.10.11
danielhollas 0ac4e15
Merge branch 'main' into python-3.10.11
danielhollas 5ae2e64
Remove traitlets install
danielhollas 6eecfe3
Merge branch 'main' into python-3.10.11
danielhollas d42e04c
Do not update zstandard, update mamba
danielhollas ac9850c
Revert full-stack fix-permission change
danielhollas 98d976c
Update zstandard
danielhollas e830af4
Update comment
danielhollas 9f65fae
Try installing mamba==2.0.0rc4
danielhollas f77b56a
Revert "Try installing mamba==2.0.0rc4"
danielhollas 7eb857e
Merge branch 'main' into python-3.10.11
danielhollas cd167e5
Pin mamba version to 1.5, 2.0 contains breaking changes
danielhollas 674e961
Run arm tests
danielhollas aeaa700
to-be-reverted: Test aiidalab-home fix
danielhollas 860a4ca
Merge branch 'main' into python-3.10.11
danielhollas 4a4e2d7
Revert "to-be-reverted: Test aiidalab-home fix"
danielhollas 98886fd
Merge branch 'main' into python-3.10.11
danielhollas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,12 +59,13 @@ COPY pip.conf "${CONDA_DIR}/pip.conf" | |
# Upgrade pip and mamba to latest | ||
# Update async_generator, certipy to satisfy `pip check` | ||
# https://github.com/aiidalab/aiidalab-docker-stack/issues/490 | ||
# Update zstandard, without this the `mamba install` command fails for unknown reason. | ||
# Install aiida-core and other shared requirements. | ||
RUN mamba update -y pip async_generator certipy && \ | ||
RUN mamba update -y pip zstandard async_generator certipy && \ | ||
mamba install --yes \ | ||
mamba=1.5 \ | ||
aiida-core==${AIIDA_VERSION} \ | ||
mamba-bash-completion \ | ||
traitlets=5.9.0 \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The base image already comes with traitlets==5.9.0 |
||
&& mamba clean --all -f -y && \ | ||
fix-permissions "${CONDA_DIR}" | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we can't easily update since those images have updated Jupiter stack with notebook v7, with which we are not compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's then go to
3.10
instead. We can further update to notebook v7 and fix the remaining things afterwards.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open a different PR for it so we can test it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure