Enable libfabric backend plugin with CXI provider for Slingshot network #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi joshishr! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
joshishr
force-pushed
the
enable_Slingshot
branch
from
bb9ee10 to
f03894a
Compare
|
The most recent force commit seems to fix the formatting changes in the checks, so I'm not sure why the checks continue to fail. |
sielicki
reviewed
Nov 25, 2025
| // TCP providers don't support FI_MR_VIRT_ADDR and expect offset-based addressing | ||
| if (data_rails_[rail_id]->provider_name == "tcp" || | ||
| if (data_rails_[rail_id]->provider_name == "cxi" || | ||
| data_rails_[rail_id]->provider_name == "tcp" || |
There was a problem hiding this comment.
@akkart-aws was there a reason you couldn't just check for FI_MR_VIRT_ADDR directly here?
Contributor
|
pls note clang format check errors |
Thank you for looking at this. I believe the force commit fixed the clang format errors, but it doesn't seem like the Clang Format Check picked up that they were fixed. |
Far as I can tell, this commit resolved the errors. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable CXI provider support in libfabric backend plugin for HPE's Slingshot network.