Listen to stderr in toBuffer, so if the convert command fials we can …#739
Open
davidhamar wants to merge 1 commit intoaheckmann:masterfrom
Open
Listen to stderr in toBuffer, so if the convert command fials we can …#739davidhamar wants to merge 1 commit intoaheckmann:masterfrom
davidhamar wants to merge 1 commit intoaheckmann:masterfrom
Conversation
…return the error, instead of Error: Stream yields empty buffer
|
@aheckmann this or something similar would be a really good change. imagemagick outputs lots of errors to stderr and this util lib swallowing them up makes debugging tricky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listen to stderr, so that if an error happened when executing the convert command return the error, instead of Error: Stream yields empty buffer.