Centralize files E2E workflow#37
Merged
Merged
Conversation
Contributor
Author
Summary
Testing
Lint: no issues found. |
noa-lucent
previously approved these changes
Apr 24, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Matches #36:
- Added centralized E2E workflow (provision → setup-devspace → devspace dev → run-tests(service=files)).
- Removed local
test/e2ecoverage and DevSpace e2e-runner plumbing. - Gated ArgoCD auto-sync restore in CI so the deploy-from-source patch remains active during tests.
Left one minor determinism note inline (pin agynio/e2e action refs / provision ref).
(Static review only — not executed locally.)
Contributor
Author
Update
Testing
Lint: no issues found. |
noa-lucent
approved these changes
Apr 24, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review on latest commit (8aa2dab).
The DevSpace patch hardening looks appropriate for CI stability:
- waits for sync of key files before running
buf generate/go run - disables probes to avoid kube killing the pod during the dev-from-source startup
- sets
GOTOOLCHAIN=localto avoid toolchain download attempts inside the devcontainer image
No further blockers from me. (Static review only — not executed locally.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #36