Skip to content

Centralize files E2E workflow#37

Merged
rowan-stein merged 2 commits into
mainfrom
noa/issue-36
Apr 24, 2026
Merged

Centralize files E2E workflow#37
rowan-stein merged 2 commits into
mainfrom
noa/issue-36

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • add centralized E2E workflow using bootstrap provision, DevSpace setup, devspace dev, and e2e run-tests
  • remove local E2E runner plumbing and delete test/e2e coverage from this repo
  • gate ArgoCD auto-sync restore in CI to keep devspace patch active

Testing

  • go test ./...
  • go vet ./...

Closes #36

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary

  • added centralized E2E workflow for files using bootstrap provision, devspace dev, and e2e run-tests
  • removed local E2E runner plumbing and deleted test/e2e sources
  • gated ArgoCD auto-sync restore during CI devspace runs

Testing

  • go test ./...
  • go vet ./...

Lint: no issues found.

noa-lucent
noa-lucent previously approved these changes Apr 24, 2026

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches #36:

  • Added centralized E2E workflow (provision → setup-devspace → devspace dev → run-tests(service=files)).
  • Removed local test/e2e coverage and DevSpace e2e-runner plumbing.
  • Gated ArgoCD auto-sync restore in CI so the deploy-from-source patch remains active during tests.

Left one minor determinism note inline (pin agynio/e2e action refs / provision ref).

(Static review only — not executed locally.)

Comment thread .github/workflows/e2e.yml
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Update

  • hardened devspace deployment patch wait loop and disabled probes to avoid CrashLoopBackOff
  • added GOTOOLCHAIN=local before go run in devspace patch

Testing

  • buf generate buf.build/agynio/api --path agynio/api/files/v1
  • go test ./...
  • go vet ./...

Lint: no issues found.

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review on latest commit (8aa2dab).

The DevSpace patch hardening looks appropriate for CI stability:

  • waits for sync of key files before running buf generate/go run
  • disables probes to avoid kube killing the pod during the dev-from-source startup
  • sets GOTOOLCHAIN=local to avoid toolchain download attempts inside the devcontainer image

No further blockers from me. (Static review only — not executed locally.)

@rowan-stein rowan-stein merged commit ca1a28a into main Apr 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Centralize E2E CI via agynio/e2e

3 participants