-
Notifications
You must be signed in to change notification settings - Fork 0
Vendor Layer Selector #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Visit the preview URL for this PR (updated for commit a898094): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR vendors the @ugrc/layer-selector package by copying its source code directly into src/vendor/layer-selector/ and removing the external npm dependency. The change provides more control over the layer selector component and eliminates an external dependency. Additionally, the PR includes updates to Bootstrap SCSS imports to resolve module compatibility issues and updates to config.json for RTP project filters and splash screen content.
Key Changes:
- Vendored layer selector component with supporting files (LayerSelector.jsx, TileInfo.js, Discover.js, LayerSelector.css, layers.svg)
- Removed
@ugrc/layer-selectorfrom package dependencies - Updated Bootstrap imports to use precompiled CSS instead of SCSS modules
- Updated config.json with new filter queries and Amendment 3 information
Reviewed changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vendor/layer-selector/LayerSelector.jsx | Main layer selector React component with expandable UI and layer management logic |
| src/vendor/layer-selector/TileInfo.js | Utility to create default TileInfo configuration for map layers |
| src/vendor/layer-selector/Discover.js | Sets up TileInfo for various Discover layer types with different zoom levels |
| src/vendor/layer-selector/LayerSelector.css | Styles for the layer selector widget |
| src/vendor/layer-selector/layers.svg | Icon graphic for the layer selector toggle button |
| src/App.jsx | Updated import to use vendored layer selector instead of npm package |
| src/App.scss | Updated to use vendored CSS file instead of npm package CSS |
| src/index.scss | Changed from @import to @use for App.scss |
| src/bootstrap.scss | Refactored to import precompiled Bootstrap CSS instead of individual SCSS modules |
| package.json | Removed @ugrc/layer-selector dependency and reorganized devDependencies |
| pnpm-lock.yaml | Updated lockfile to reflect dependency removal |
| pnpm-workspace.yaml | Added build configuration for native dependencies |
| public/config.json | Updated filter queries for HOT Lane and Active Transportation, plus splash screen Amendment 3 text |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
steveoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this Scott. I'm curious if the simplified sass imports caused any unwanted design changes?
I did not see any differences in the app. I did click through a bunch of stuff to make sure that it still worked. |
No description provided.