Upgrade supported Kubernetes versions to 1.34, 1.35, 1.36 by Sivasankaran25 · Pull Request #4664 · agones-dev/agones

Sivasankaran25 · 2026-07-29T15:01:22Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Works On #4655

Did you use AI tools in preparing this PR?:

Y/N

Special notes for your reviewer:

github-actions · 2026-07-29T15:20:22Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

…hinery upgrade

github-actions · 2026-07-29T15:49:16Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2026-07-29T16:26:40Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

igooch

One blocking item (the terraform rotation), a couple worth resolving, details inline.

igooch · 2026-07-31T19:56:37Z

    "1.34" = ["us-east1", "RAPID"]
    "1.35" = ["us-west1", "RAPID"]
-    //"1.36" = ["us-west1", "RAPID"]
+    "1.36" = ["us-west1", "RAPID"]


Same two-phase issue as build/terraform/e2e/module.tf — 1.33 is removed in the same PR that adds 1.36.

It looks like something got out of order here, as 1.35 and 1.36 should be in different regions. 1.36 should be us-central1 and 1.37 us-east1.

igooch · 2026-07-31T19:56:38Z

 #   |___/                                               |___/

-grpc_release_tag = v1.80.0
+grpc_release_tag = v1.83.0


v1.83.0 doesn't match google.golang.org/grpc v1.82.1 in go.mod. Please double check that the versions is consistent across the repo.

markmandel · 2026-08-02T00:05:50Z

Did we delete the currently supported test clusters?

I noticed #4669 failed on:

https://console.cloud.google.com/cloud-build/builds/0d0c3ebf-3b3d-4829-9d8b-e1535adb59c6;step=1?project=agones-images

Already have image: e2e-runner
PlayerAllocationFilter=true&FleetAutoscaleRequestMetaData=false&PlayerTracking=true&CountsAndLists=false&ScheduledAutoscaler=false&GKEAutopilotExtendedDurationPods=false&SidecarContainers=false&WasmAutoscaler=true&Example=true
Fetching cluster endpoint and auth data.
ERROR: (gcloud.container.clusters.get-credentials) ResponseError: code=404, message=Not found: projects/agones-images/locations/asia-east1/clusters/gke-autopilot-e2e-test-cluster-1-33. This command is authenticated as 258182270954@cloudbuild.gserviceaccount.com which is the active account specified by the [core/account] property.
No cluster named 'gke-autopilot-e2e-test-cluster-1-33' in agones-images.

Which is a problem, since that without that PR, CI is broken...

if we need to do a quick fix, add back in these lines, but line it up with the 0.15.0 release of Doscy - it should work.
https://github.com/agones-dev/agones/pull/4593/changes#diff-8b720a6c52c203c73c71c632d2087b411c532e506a86830eed851baaf96b61d1

github-actions · 2026-08-02T18:43:48Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

markmandel · 2026-08-02T21:59:49Z

/gcbrun

github-actions · 2026-08-02T22:45:43Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

markmandel · 2026-08-02T22:45:50Z

Just a heads up - I put the fix in that should solve the issue with Docsy not being locked to 0.15.0 🤞🏻

markmandel · 2026-08-02T22:55:43Z

@Sivasankaran25 - you'll need to fix your DCO commits.

* Fix for CI issue blocking the building of the site (lock to docsy 0.15.0) * Run `go mod tidy` for simple-game-server Signed-off-by: Mark Mandel <mark@compoundtheory.com>

github-actions · 2026-08-02T23:13:33Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

markmandel · 2026-08-03T00:52:51Z

Yay it passed!

@Sivasankaran25 if you fix the DCO, then @igooch can wrap this up, and we can unstick CI 😄

igooch

Two additional small findings in line:

igooch · 2026-08-03T16:47:26Z

 require gopkg.in/yaml.v2 v2.4.0
+
+require (
+	github.com/google/docsy v0.15.0 // indirect


Two small things: docsy is a direct dependency of the site build, so the // indirect markers look wrong, and the file is missing its trailing newline. A go mod tidy in site/ should fix both.

Leave this as is please. It works and unblocks CI (and it's how we did it before). #4669 solves this properly.

igooch · 2026-08-03T17:19:00Z

    "1.34" = ["us-east1", "RAPID"]
    "1.35" = ["us-west1", "RAPID"]
-    //"1.36" = ["us-west1", "RAPID"]
+    "1.36" = ["us-west1", "RAPID"]


It looks like something got out of order here, as 1.35 and 1.36 should be in different regions. 1.36 should be us-central1 and 1.37 us-east1.

github-actions · 2026-08-03T19:24:39Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

igooch

LGTM

Upgrade supported Kubernetes versions to 1.34, 1.35, 1.36

8c93078

Sivasankaran25 requested review from igooch and vicentefb July 29, 2026 15:01

Sivasankaran25 self-assigned this Jul 29, 2026

github-actions Bot added kind/breaking Breaking change size/XL labels Jul 29, 2026

fix: update GameServer validation test expectations for k8s.io/apimac…

be00721

…hinery upgrade

fix: regenerate go.mod/go.sum for nested example modules

2f537a7

igooch reviewed Jul 31, 2026

View reviewed changes

Update k8s upgrade PR per review comments

17f2cb5

CI Fixes and related

d1d3b9f

* Fix for CI issue blocking the building of the site (lock to docsy 0.15.0) * Run `go mod tidy` for simple-game-server Signed-off-by: Mark Mandel <mark@compoundtheory.com>

markmandel force-pushed the upgrade1.36/k8 branch from bd0eb8a to d1d3b9f Compare August 2, 2026 23:13

igooch reviewed Aug 3, 2026

View reviewed changes

Change cluster region in upgrade

a8aae18

igooch approved these changes Aug 3, 2026

View reviewed changes

igooch enabled auto-merge (squash) August 3, 2026 20:12

igooch merged commit c6107c4 into agones-dev:main Aug 3, 2026
4 checks passed

Uh oh!

Conversation

Sivasankaran25 commented Jul 29, 2026

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

igooch Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Sivasankaran25 Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

igooch Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

igooch Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

markmandel commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

markmandel commented Aug 2, 2026

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

markmandel commented Aug 2, 2026

Uh oh!

markmandel commented Aug 2, 2026

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

markmandel commented Aug 3, 2026

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

igooch Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

markmandel Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

igooch Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

markmandel commented Aug 2, 2026 •

edited

Loading