fix: mark GameServer Unhealthy when the game container terminates and the Pod stays Running - #4663
Conversation
Signed-off-by: Subham K. <me@growly.gg>
|
We hit this exact case in production with Agones v1.57 and The container referenced by With Since Using the designated game container as the lifecycle signal is the behavior we expected. A terminated game container cannot recover under |
What type of PR is this?
/kind bug
What this PR does / Why we need it:
I have a cluster with a Fleet that provisiones GameServers with a game container and several other sidecar containers. We had an issue where our main game container OOMKilled, but the pod stayed and was not replaced by Agones.
In
failedContainer, when SidecarContainers is enabled, then it falls back to the Kubernetes behavior which requires every container in the pod to fail before the pod is marked as Failed.This PR makes it so
failedContainerreports the pod as Failed when the primary game container has terminated.Which issue(s) this PR fixes:
N/A
Did you use AI tools in preparing this PR?:
Used for codegen & verifying the fix works
Special notes for your reviewer:
N/A