build: regen messages on test-gen-crd-code and test-gen-all-sdk-grpc - #4662
Open
markmandel wants to merge 1 commit into
Open
build: regen messages on test-gen-crd-code and test-gen-all-sdk-grpc#4662markmandel wants to merge 1 commit into
markmandel wants to merge 1 commit into
Conversation
Matches the existing pattern from test-install-yaml and test-gen-api-docs, which already tell the user which make target to run to fix the diff. diff-directory (used by test-gen-crd-code) also now exits 1 on a diff, since it previously only printed the diff without failing the build. Signed-off-by: Mark Mandel <mark@compoundtheory.com>
github-actions
Bot
added
kind/cleanup
lacroixthomas
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Matches the existing pattern from test-install-yaml and test-gen-api-docs, which already tell the user which make target to run to fix the diff. diff-directory (used by test-gen-crd-code) also now exits 1 on a diff, since it previously only printed the diff without failing the build.
Which issue(s) this PR fixes:
N/A
Did you use AI tools in preparing this PR?:
Y
Special notes for your reviewer:
Just making it easier for people to self serve into fixes.