Skip to content

build: update golang dependencies across all go.mod files - #4659

Open
Ribhu-bhardwaj wants to merge 3 commits into
agones-dev:mainfrom
Ribhu-bhardwaj:update-dependencies
Open

build: update golang dependencies across all go.mod files#4659
Ribhu-bhardwaj wants to merge 3 commits into
agones-dev:mainfrom
Ribhu-bhardwaj:update-dependencies

Conversation

@Ribhu-bhardwaj

Copy link
Copy Markdown
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it: This is the PR2 for #4620

Which issue(s) this PR fixes: dependency upgrades.

Closes #4620

Did you use AI tools in preparing this PR?:

Y

Special notes for your reviewer:

Signed-off-by: Ribhu-bhardwaj <bhardwajribhu@gmail.com>
@github-actions

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@markmandel

Copy link
Copy Markdown
Member

/gcbrun

@markmandel

Copy link
Copy Markdown
Member

Looks like this needs a make gen-all-sdk-grpc to regenerate the swagger files - since grpc-gateway got bumped.

@markmandel

Copy link
Copy Markdown
Member

I should learn to check CI first before approving things :D

@Ribhu-bhardwaj

Copy link
Copy Markdown
Contributor Author

mark i dont understand some parts of this . Basically it was a file mismatch right between what was expected and what was in the code. If this is the case I'm sorry and i will try to fix it!

@markmandel

Copy link
Copy Markdown
Member

mark i dont understand some parts of this . Basically it was a file mismatch right between what was expected and what was in the code. If this is the case I'm sorry and i will try to fix it!

You got it! We can improve that error too in CI.

Signed-off-by: ribs <143743519+Ribhu-bhardwaj@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@markmandel

Copy link
Copy Markdown
Member

/gcbrun

@Ribhu-bhardwaj

Copy link
Copy Markdown
Contributor Author

Hey mark it appears to be failing still -I feel 13 minutes isnt that bad and i dont have access to the logs so cant figure out the tweaks needed.

@markmandel

Copy link
Copy Markdown
Member

Our github bot is currently broken (secret needs a rotation), but to get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel

Copy link
Copy Markdown
Member

Ah this isn't your fault, this is the same CI issue we have that's solved in #4669 - it blocked CI.

@markmandel

Copy link
Copy Markdown
Member

This should be better now, but we did just do a huge dependency update with the K8s upgrade - can you fix the conflicts, and we can try again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Golang 1.26.4 Version and Dependency Upgrades

2 participants