Skip to content

fix(controller): gate AuthenticationConfig::Spire match for windows - #1859

Merged
muscariello merged 1 commit into
mainfrom
fix/controller-windows-spire
Jul 16, 2026
Merged

fix(controller): gate AuthenticationConfig::Spire match for windows#1859
muscariello merged 1 commit into
mainfrom
fix/controller-windows-spire

Conversation

@muscariello

@muscariello muscariello commented Jul 16, 2026

Copy link
Copy Markdown
Member

Follow-up to #1855. AuthenticationConfig::Spire is cfg(not(windows)) in slim-config, but controller's derive_auth matched on it unconditionally (service.rs:217), so the crate fails to compile on windows (no variant Spire). Compute auth_is_spire behind a cfg (false on windows).

Surfaced by a2a-rs windows CI (#104) once slim-config 0.12.2 fixed the config-internal refs. control-plane also references the gated variant but isn't in a2a-slimrpc's tree; controller is the last one on that path. Host build + clippy + fmt clean.

@muscariello
fix(controller): gate AuthenticationConfig::Spire match for windows
c3bb7ed 
AuthenticationConfig::Spire is cfg(not(windows)) in slim-config, but
controller's derive_auth matched on it unconditionally, so the crate
failed to compile on windows. Compute `auth_is_spire` behind a cfg (false
on windows). Mirrors slim-config#1855.

Signed-off-by: Luca Muscariello <muscariello@ieee.org>
@muscariello
muscariello requested a review from a team as a code owner July 16, 2026 06:54
@muscariello
muscariello requested review from micpapal and msardara July 16, 2026 07:29
@muscariello
muscariello merged commit c588f69 into main Jul 16, 2026
11 checks passed
@muscariello
muscariello deleted the fix/controller-windows-spire branch July 16, 2026 07:30
@build-agntcy build-agntcy mentioned this pull request Jul 16, 2026
Merged
msardara added a commit that referenced this pull request Jul 16, 2026
@msardara
Merge remote-tracking branch 'origin/main' into 1808-featslim-binding…
f9158f6 
…s-expose-offline-channel-membership-and-session-persistence

* origin/main:
  fix(controller): gate AuthenticationConfig::Spire match for windows (#1859)
  chore: release (#1856)
  ci: exempt org members from DCO + scope release secrets to an environment (#1857)
  fix(config): gate RequiredAuthMethod::Spire for windows (#1855)
  chore: release (#1854)
  chore: release (#1853)
  chore(rpc): version agntcy-slim-rpc on the 2.0.0-alpha line (#1852)
  chore(docs): updating gh pulse widget (#1848)
  refactor(slim-bindings): reuse agntcy-slim-rpc, drop duplicated slimrpc (#1850)
  feat(rpc): extract native agntcy-slim-rpc crate from the FFI bindings (#1830)
  chore: move slim-bindings back to slim core (#1846)
  ci: disable docker build on PRs (#1845)
  ci: drop benchmark concurrency block that breaks the nightly reusable call (#1844)
  ci: move wasm test suites off the PR path to nightly (#1841)
  ci: move coverage and benchmark off the PR path (#1840)
  feat(mls): share one signing identity across an app and its sessions (#1825)
  ci: run coverage once, move release builds and e2e tests to nightly (#1837)
  fix(control-plane): re-expand routes when a node reconnects over a claimed link (#1836)
muscariello pushed a commit that referenced this pull request Jul 16, 2026
@build-agntcy
chore: release (#1860)
7868567 
## 🤖 New release

* `agntcy-slim-config`: 0.12.2 -> 0.12.3 (✓ API compatible changes)
* `agntcy-slim-controller`: 0.11.1 -> 0.11.2 (✓ API compatible changes)
* `agntcy-slim-proto`: 0.3.1 -> 0.3.2
* `agntcy-slim-tracing`: 0.4.4 -> 0.4.5
* `agntcy-slim-datapath`: 0.16.3 -> 0.16.4
* `agntcy-slim-session`: 0.5.2 -> 0.5.3
* `agntcy-slim-service`: 0.11.2 -> 0.11.3
* `agntcy-slim`: 2.0.0-alpha.4 -> 2.0.0-alpha.5
* `agntcy-slim-channel-manager`: 2.0.0-alpha.4 -> 2.0.0-alpha.5
* `agntcy-slim-control-plane`: 2.0.0-alpha.4 -> 2.0.0-alpha.5
* `agntcy-slim-rpc`: 2.0.0-alpha.4 -> 2.0.0-alpha.5
* `agntcy-slim-bindings`: 2.0.0-alpha.5 -> 2.0.0-alpha.6
* `agntcy-slimctl`: 2.0.0-alpha.4 -> 2.0.0-alpha.5

<details><summary><i><b>Changelog</b></i></summary><p>

## `agntcy-slim-config`

<blockquote>

##
[0.12.3](slim-config-v0.12.2...slim-config-v0.12.3)
- 2026-07-16

### Other

- update Cargo.lock dependencies
</blockquote>

## `agntcy-slim-controller`

<blockquote>

##
[0.11.2](slim-controller-v0.11.1...slim-controller-v0.11.2)
- 2026-07-16

### Fixed

- *(controller)* gate AuthenticationConfig::Spire match for windows
([#1859](#1859))
</blockquote>

## `agntcy-slim-proto`

<blockquote>

##
[0.3.2](slim-proto-v0.3.1...slim-proto-v0.3.2)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config
</blockquote>

## `agntcy-slim-tracing`

<blockquote>

##
[0.4.5](slim-tracing-v0.4.4...slim-tracing-v0.4.5)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config
</blockquote>

## `agntcy-slim-datapath`

<blockquote>

##
[0.16.4](slim-datapath-v0.16.3...slim-datapath-v0.16.4)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-proto, agntcy-slim-tracing
</blockquote>

## `agntcy-slim-session`

<blockquote>

##
[0.5.3](slim-session-v0.5.2...slim-session-v0.5.3)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-datapath
</blockquote>

## `agntcy-slim-service`

<blockquote>

##
[0.11.3](slim-service-v0.11.2...slim-service-v0.11.3)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-controller, agntcy-slim-datapath, agntcy-slim-session
</blockquote>

## `agntcy-slim`

<blockquote>

##
[2.0.0-alpha.5](slim-v2.0.0-alpha.4...slim-v2.0.0-alpha.5)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-tracing, agntcy-slim-service
</blockquote>

## `agntcy-slim-channel-manager`

<blockquote>

##
[2.0.0-alpha.5](slim-channel-manager-v2.0.0-alpha.4...slim-channel-manager-v2.0.0-alpha.5)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-config, agntcy-slim-proto, agntcy-slim-tracing,
agntcy-slim-datapath, agntcy-slim-datapath, agntcy-slim-session,
agntcy-slim-service, agntcy-slim
</blockquote>

## `agntcy-slim-control-plane`

<blockquote>

##
[2.0.0-alpha.5](slim-control-plane-v2.0.0-alpha.4...slim-control-plane-v2.0.0-alpha.5)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-config, agntcy-slim-proto, agntcy-slim-tracing,
agntcy-slim-tracing, agntcy-slim-datapath, agntcy-slim-datapath,
agntcy-slim-service
</blockquote>

## `agntcy-slim-rpc`

<blockquote>

##
[2.0.0-alpha.5](slim-rpc-v2.0.0-alpha.4...slim-rpc-v2.0.0-alpha.5)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-datapath, agntcy-slim-session, agntcy-slim-service
</blockquote>

## `agntcy-slim-bindings`

<blockquote>

##
[2.0.0-alpha.6](slim-bindings-v2.0.0-alpha.5...slim-bindings-v2.0.0-alpha.6)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-controller, agntcy-slim-tracing, agntcy-slim-datapath,
agntcy-slim-session, agntcy-slim-service, agntcy-slim, agntcy-slim-rpc
</blockquote>

## `agntcy-slimctl`

<blockquote>

##
[2.0.0-alpha.5](slimctl-v2.0.0-alpha.4...slimctl-v2.0.0-alpha.5)
- 2026-07-16

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-proto, agntcy-slim-tracing, agntcy-slim-datapath,
agntcy-slim-session, agntcy-slim-service, agntcy-slim
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
muscariello added a commit to a2aproject/a2a-rs that referenced this pull request Jul 16, 2026
@muscariello
build: pull agntcy-slim-controller 0.11.2 for the windows build fix
75e860c 
controller 0.11.2 cfg-gates the AuthenticationConfig::Spire match for
windows (agntcy/slim#1859), the last slim crate in a2a-slimrpc's windows
dependency tree that failed to compile. Lock-only; host build unchanged.

Signed-off-by: Luca Muscariello <muscariello@ieee.org>
@build-agntcy build-agntcy mentioned this pull request Jul 16, 2026
Merged
muscariello added a commit to a2aproject/a2a-rs that referenced this pull request Jul 16, 2026
@muscariello
feat(slimrpc)!: migrate a2a-slimrpc onto native agntcy-slim-rpc (#104)
4a0f7a5 
* feat(slimrpc)!: migrate a2a-slimrpc onto native agntcy-slim-rpc

Repoint a2a-slimrpc off the UniFFI shim (agntcy-slim-bindings) onto the
native SlimRPC crate agntcy-slim-rpc (2.0.0-alpha.3), dropping the entire
UniFFI stack from the A2A dependency chain.

- Deps: replace slim_bindings with slim_rpc + native slim_service (App),
  slim_datapath (ProtoName) and slim_auth (auth provider/verifier).
- RPC types (Channel/Server/Context/RpcError/RpcCode/StreamMessage) now
  come from slim_rpc.
- App/Name become native types: SlimApp = slim_service::app::App<AuthProvider,
  AuthVerifier> and slim_datapath::api::ProtoName. parse_slimrpc_target now
  splits the target into org/namespace/agent and builds ProtoName::from_strings.
- e2e tests build apps via slim_service Service::create_app instead of the FFI
  App constructor. All unit + e2e tests pass; clippy -D warnings + fmt clean.

BREAKING CHANGE: SlimRpcTransport/Factory now take native App/Name types
instead of the agntcy-slim-bindings FFI types. Bump to 0.2.0.

Signed-off-by: Luca Muscariello <muscariello@ieee.org>

* fix(a2a-pb): allow useless_borrows_in_formatting in generated serde

Newer clippy flags `write!(f, "...", &FIELDS)` in the pbjson-generated serde
code as a useless borrow, failing `-D warnings` on CI (which uses latest
stable; the repo pins no toolchain). Scope an allow to the generated
`protojson` module.

Signed-off-by: Luca Muscariello <muscariello@ieee.org>

* build: pull agntcy-slim-config 0.12.2 for the windows build fix

slim-config 0.12.2 cfg-gates RequiredAuthMethod::Spire for windows
(agntcy/slim#1855), fixing the windows compile of the native slim stack
that a2a-slimrpc now depends on. Lock-only bump; host build unchanged.

Signed-off-by: Luca Muscariello <muscariello@ieee.org>

* build: pull agntcy-slim-controller 0.11.2 for the windows build fix

controller 0.11.2 cfg-gates the AuthenticationConfig::Spire match for
windows (agntcy/slim#1859), the last slim crate in a2a-slimrpc's windows
dependency tree that failed to compile. Lock-only; host build unchanged.

Signed-off-by: Luca Muscariello <muscariello@ieee.org>

---------

Signed-off-by: Luca Muscariello <muscariello@ieee.org>
msardara added a commit that referenced this pull request Jul 16, 2026
@msardara
Merge remote-tracking branch 'origin/main' into feat/remove-slimrpc-f…
6b983a6 
…rom-bindings

* origin/main:
  fix(auth,mls): stop mid-handshake MLS signing-key rotation (#1869)
  fix(docs): main page rendering in mobile view (#1863)
  chore: release (#1860)
  chore: release (#1858)
  fix(controller): gate AuthenticationConfig::Spire match for windows (#1859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msardara msardara msardara approved these changes
@micpapal micpapal Awaiting requested review from micpapal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@muscariello @msardara