Skip to content

fix(ui): distinguish catalog status icons - #1955

Open
lntutor wants to merge 1 commit into
agntcy:mainfrom
lntutor:fix/catalog-status-icons
Open

fix(ui): distinguish catalog status icons#1955
lntutor wants to merge 1 commit into
agntcy:mainfrom
lntutor:fix/catalog-status-icons

Conversation

@lntutor

@lntutor lntutor commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #1933.

  • use a plain shield for clean scans, a shield with an exclamation for lower-severity findings, and a warning triangle for high or critical findings
  • use a check-circle for trusted entries and a lock for verified ownership so those states no longer share the same glyph
  • rebuild the checked-in catalog UI assets

Verification

  • npm run check (0 errors; two pre-existing warnings)
  • npm run build

npm run lint remains blocked by eight pre-existing Prettier failures in unrelated files.

Signed-off-by: Loi Nguyen <vanloi999@gmail.com>
@lntutor
lntutor requested a review from a team as a code owner July 31, 2026 20:03
@github-actions github-actions Bot added the size/XS Denotes a PR that changes 0-49 lines label Jul 31, 2026
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@lntutor

lntutor commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Current head 1d6df81f4471383c1d6a1f61508f1d88cf652ecc is mergeable, the visible CI/coverage/DCO checks on this head are green, and there are no unresolved review threads on the current PR state. This looks ready for maintainer review when convenient.

@csirmazbendeguz

csirmazbendeguz commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

I have tested out this branch and I'm including the screenshots:

Safe=yes

Safe=yes, MaxSeverity=Medium (orange)

Screenshot 2026-08-03 at 13 58 25

Safe=yes, MaxSeverity=Low (blue)

Screenshot 2026-08-03 at 14 24 35

Safe=yes, MaxSeverity=None (green)

Screenshot 2026-08-03 at 14 26 25

Safe=no, MaxSeverity=High,Critical

Safe=no, MaxSeverity=Critical (red)

Screenshot 2026-08-03 at 14 12 25

Safe=no, MaxSeverity=High (dark orange)

Screenshot 2026-08-03 at 14 15 49

Safe=no, MaxSeverity=Medium,Low,None

Safe=no, MaxSeverity=Medium (orange)

Screenshot 2026-08-03 at 14 19 55

Safe=no, MaxSeverity=Low (blue)

Screenshot 2026-08-03 at 14 21 38

Safe=no, MaxSeverity=None (green)

Screenshot 2026-08-03 at 14 22 53

@csirmazbendeguz csirmazbendeguz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

We have made some adjustments to the issue (#1933). I understand it wasn't 100% clear, we didn't consider the issue thoroughly and we only realized the problem after reviewing your PR

We decided to simplify the logic around the shield badges. Please check the issue and adjust your PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-49 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accessibility] Improve AI Catalog card icons

2 participants