refactor(config): introduce config module - #1732
Draft
paralta wants to merge 9 commits into
Draft
Conversation
…nfig Signed-off-by: Catarina Paralta <clouropa@cisco.com>
…efix and updating related references Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
2 tasks
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
paralta
force-pushed
the
refactor/dir-config-module
branch
from
July 1, 2026 09:46
3875524 to
47de022
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Member
Author
|
These changes will not be included in https://github.com/agntcy/dir/milestone/14, thus keeping this PR as draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR establishes a new
config/Go module as the single source of truth for all configuration types across the monorepo. Previously, each service (apiserver, reconciler, daemon) owned fragmented config packages —server/config,server/database/config,server/store/oci/config,reconciler/config, and a dozen sub-serviceconfig.gofiles — that duplicated type definitions, viper wiring, and defaults. All of those are now deleted and replaced by theconfigmodule plus aconfig/reconciler sub-package for reconciler task types.