Skip to content

fix(http): preserve custom finch in sync requests#617

Merged
mikehostetler merged 1 commit intomainfrom
fix/616-preserve-custom-finch
Apr 17, 2026
Merged

fix(http): preserve custom finch in sync requests#617
mikehostetler merged 1 commit intomainfrom
fix/616-preserve-custom-finch

Conversation

@mikehostetler
Copy link
Copy Markdown
Contributor

Summary

  • preserve an existing Req.Request finch option instead of overwriting it during non-streaming provider attach
  • apply the shared finch preservation logic to explicit attach implementations that bypass ReqLLM.Provider.Defaults.default_attach/4
  • add regression coverage for the shared defaults path and sync OpenAI/Azure request preparation

Closes #616

Validation

  • mix test test/providers/openai_test.exs test/provider/azure/azure_test.exs test/req_llm/step/retry_test.exs
  • mix quality

@mikehostetler mikehostetler merged commit f2c300c into main Apr 17, 2026
7 checks passed
@mikehostetler mikehostetler deleted the fix/616-preserve-custom-finch branch April 17, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Non-streaming requests ignore req_http_options[:finch] due to attach/3 overwrite

1 participant