Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/generate.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ async function main() {

export const CLIENT_METHODS = ${JSON.stringify(metadata.clientMethods, null, 2)} as const;

export const PROTOCOL_METHODS = ${JSON.stringify(metadata.protocolMethods, null, 2)} as const;

export const PROTOCOL_VERSION = ${metadata.version};
`,
{ parser: "typescript" },
Expand Down
80 changes: 77 additions & 3 deletions src/acp.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,8 @@ describe("Connection", () => {
const appAgent = createAgent({ name: "app-agent" })
.onRequest(AGENT_METHODS.initialize, (c) => {
events.push(`initialize:${c.params.protocolVersion}`);
expect(Object.keys(c).sort()).toEqual(["client", "params"]);
expect(Object.keys(c).sort()).toEqual(["client", "params", "signal"]);
expect(c.signal.aborted).toBe(false);

return {
protocolVersion: c.params.protocolVersion,
Expand All @@ -742,7 +743,7 @@ describe("Connection", () => {
},
},
(c) => {
expect(Object.keys(c).sort()).toEqual(["client", "params"]);
expect(Object.keys(c).sort()).toEqual(["client", "params", "signal"]);
events.push(`agent-route:${String(c.params.message)}`);
},
)
Expand Down Expand Up @@ -777,7 +778,8 @@ describe("Connection", () => {
return { message: String(message).toUpperCase() };
},
(c) => {
expect(Object.keys(c).sort()).toEqual(["agent", "params"]);
expect(Object.keys(c).sort()).toEqual(["agent", "params", "signal"]);
expect(c.signal.aborted).toBe(false);
events.push(`client-route:${String(c.params.message)}`);

return { message: c.params.message };
Expand Down Expand Up @@ -824,6 +826,78 @@ describe("Connection", () => {
]);
});

it("aborts app request context signals for protocol cancellation", async () => {
const requestSignal = Promise.withResolvers<AbortSignal>();

const appAgent = createAgent({ name: "cancel-signal-agent" }).onRequest(
"vendor/slow",
(params) => params as Record<string, never>,
async (c) => {
requestSignal.resolve(c.signal);
await new Promise<void>((resolve) => {
c.signal.addEventListener("abort", () => resolve(), { once: true });
});

return { cancelled: c.signal.aborted };
},
);
const appClient = createClient({ name: "cancel-signal-client" });

const result = await appClient.connectWith(appAgent, async (agentCx) => {
const response = agentCx.request<{ cancelled: boolean }>(
"vendor/slow",
{},
);
const signal = await requestSignal.promise;

expect(signal.aborted).toBe(false);
await agentCx.notify(methods.protocol.cancelRequest, { requestId: 0 });

return response;
});

expect(result).toEqual({ cancelled: true });
});

it("maps app request abort errors to request cancellation", async () => {
const requestSignal = Promise.withResolvers<AbortSignal>();

const appAgent = createAgent({ name: "abort-error-agent" }).onRequest(
"vendor/abort",
(params) => params as Record<string, never>,
async (c) => {
requestSignal.resolve(c.signal);
await new Promise<void>((_, reject) => {
c.signal.addEventListener(
"abort",
() => {
const error = new Error("aborted");
error.name = "AbortError";
reject(error);
},
{ once: true },
);
});

return {};
},
);
const appClient = createClient({ name: "abort-error-client" });

await appClient.connectWith(appAgent, async (agentCx) => {
const response = agentCx.request("vendor/abort", {});
const signal = await requestSignal.promise;

expect(signal.aborted).toBe(false);
await agentCx.notify(methods.protocol.cancelRequest, { requestId: 0 });

await expect(response).rejects.toMatchObject({
code: -32800,
message: "Request cancelled",
});
});
});

it("returns peer contexts from app connection handles", async () => {
const events: string[] = [];

Expand Down
Loading