Validate install prerequisites - #747
Open
Brendan Burns (brendandburns) wants to merge 3 commits into
Open
Conversation
Tim Hockin (thockin)
left a comment
Tim Hockin (thockin)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this
| local status="" | ||
| status="$(git status --porcelain --untracked-files=normal)" | ||
| if [[ -n "${status}" ]]; then | ||
| echo "Error: ko requires a clean Git worktree, but local changes were found:" >&2 |
Collaborator
There was a problem hiding this comment.
s/ko/this operation/ ?
| } | ||
|
|
||
| check_go() { | ||
| if ! command -v go >/dev/null 2>&1; then |
Collaborator
There was a problem hiding this comment.
require_command go ?
|
|
||
| check_go_tool_ko() { | ||
| if ! ( | ||
| cd "${ROOT}/hack/tools/ko" && |
Collaborator
There was a problem hiding this comment.
given that this is in the repo, in a tool that we manage, how would it possibly fail here ?
Also ./hack/run-tool.sh ko
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add checks for three prerequisites which I hit when I was installing using a fresh system.