MaxZX #1167
Draft
MaxZX #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixwellen
reviewed
Nov 14, 2024
| ; isCommRing = isCommRingℤ | ||
| } | ||
|
|
||
| ℤCommRing : CommRing Agda.Primitive.lzero |
There was a problem hiding this comment.
That is already in Cubical.Algebra.CommRing.Instances.Int
felixwellen
reviewed
Nov 14, 2024
|
|
||
| ℤ[X]CommRing : CommRing Agda.Primitive.lzero | ||
| ℤ[X]CommRing = record | ||
| { fst = Poly ℤCommRing |
There was a problem hiding this comment.
Cubical.Algebra.CommRing.Instances.Polynomials.UnivariatePolyList should be used.
felixwellen
reviewed
Nov 14, 2024
|
|
||
|
|
||
| data 𝕌 : Set where | ||
| u : 𝕌 |
There was a problem hiding this comment.
Type should be used instead of Set
felixwellen
reviewed
Nov 14, 2024
| ; isCommRing = isCommRingℤ[X] | ||
| } | ||
|
|
||
| ℤ[X]CommRing : CommRing Agda.Primitive.lzero |
There was a problem hiding this comment.
ℓ-zero should be used instead of Agda.Primitive.lzero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should become a constructive Characterisation of the explicit maximal ideals in Z[X]