-
Notifications
You must be signed in to change notification settings - Fork 251
[ refactor ] make n≢i : n ≢ toℕ i
argument to lower₁
irrelevant
#2783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamesmckinna
wants to merge
8
commits into
agda:master
Choose a base branch
from
jamesmckinna:Fin-lower-properties
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquesCarette
requested changes
Jul 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo my comment on whether we even need those extra 2 lemmas, I'm now happy with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2748 made me rethink whether
Data.Fin.Base.lower₁
is fit-for-purpose (as an inverse toinject₁
), or could instead be deprecated in favour of the newData.Fin.Base.lower
...This PR doesn't entirely solve that issue, but does prove the two definitions extensionally equal on their domains, as a consequence, perhaps more importantly, of weakening the type of
lower₁
so that its precondition is made irrelevant.Two (possibly more downstream) knock-on consequences:
lemmaavoided in favour of [ refactor ] weaken type oflower₁-¬0≢0 : ∀ {ℓ} {A : Set ℓ} → .(0 ≢ 0) → A
encapsulates a repeated pattern of (¬-recompute
) reasoning, which ideally would be madeprivate
, but is needed in bothBase
andProperties
... so, reluctantly, has been added;Relation.Nullary.Negation.Core.contradiction-irr
#2785 on which this PR is nowblocked
.lower₁
could/should be simplified by delegation to those forlower
...?i ≢ j
argument toData.Fin.Base.punchOut
irrelevant #2790Data.Fin.Base.punchOut
and its properties could similarly be weakened by making itsi≢j : i ≢ j
argument irrelevant! What else might be susceptible to this kind of refactoring?NB. As observed/observable in
README.Data.Fin.Relation.Unary.Top
, we can actually avoid having any uses oflower₁
in the library, sodeprecation
seems possible/desirable #2786UPDATED: no longer
blocked
on #2785 .