Skip to content

Transforme le listing d'inscription en Controller Symfony #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Zarlokh
Copy link
Contributor

@Zarlokh Zarlokh commented May 8, 2025

Déplace la page de liste des inscriptions d'un évènement dans Symfony

@Zarlokh
Copy link
Contributor Author

Zarlokh commented May 8, 2025

Hello @agallou @Mopolo @stakovicz
J'ai mis la PR en draft pour l'instant car pas tout finis (il manque une partie nettoyage notamment)
J'ai plusieurs questions à vous poser pour savoir ce que je fais ou pas, je vous l'indique en ciblant le code

@Zarlokh Zarlokh force-pushed the feature/move-inscription-page-to-sf branch from 76a81a4 to 312160e Compare May 8, 2025 06:00
$sort = $request->query->get('sort');
$filter = $request->query->get('filter');

$event = $id ? $eventActionHelper->getEventById($id) : $eventRepository->getLastEvent();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas besoin de vérifier si l'id est null, le helper le fait déjà.

AFUP_FORUM_SPECIAL_PRICE => 0,
],
'event' => $event,
'event_select_form' => $this->createForm(EventSelectType::class, $event)->createView(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ici tu peux utiliser \AppBundle\Event\Form\Support\EventSelectFactory pour avoir la gestion automatique du switch d'event comme sur les autres pages.

Tu trouveras un exemple dans \AppBundle\Controller\Admin\Event\RoomAction

@Mopolo
Copy link
Contributor

Mopolo commented May 28, 2025

ℹ️ T'auras peut-être un micro conflit avec cette PR : #1822

Raphael added 2 commits May 28, 2025 19:28
…ode rapidement + remplace les liens par la fonction path de twig + corrige un bug quand on tente de générer une inscription pour une personne
@Zarlokh Zarlokh force-pushed the feature/move-inscription-page-to-sf branch from 230b70a to 386f996 Compare May 28, 2025 17:29
@Zarlokh Zarlokh changed the title feature/move-inscription-page-to-sf : WIP Transforme le listing d'inscription en Controller Symfony May 28, 2025
@Zarlokh Zarlokh marked this pull request as ready for review May 28, 2025 22:59
… conversion des messages flash legacy au nouveua format des messages flash
@Zarlokh Zarlokh requested review from agallou and Mopolo May 31, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants