Fix LetsEncrypt breakage following discontinued support for sending expiration notifications#76
Open
sasani72 wants to merge 1 commit intoafosto:masterfrom
Open
Fix LetsEncrypt breakage following discontinued support for sending expiration notifications#76sasani72 wants to merge 1 commit intoafosto:masterfrom
sasani72 wants to merge 1 commit intoafosto:masterfrom
Conversation
Contributor
|
Hello, i'm working on the same issue and just found your PR. Tested succesfully and is already working in production. Thanks! |
Author
Happy to hear it was helpful! @bakkerpeter hope you see this and be willing to merge it. |
|
For anyone needing a fix right now until the maintainer merge this you can use the following: |
lordelph
added a commit
to lordelph/yaac
that referenced
this pull request
Jul 9, 2025
Temporary fix for afosto#76
lordelph
added a commit
to lordelph/yaac
that referenced
this pull request
Jul 9, 2025
temp fix following afosto#76
binsky08
approved these changes
Jul 14, 2025
binsky08
left a comment
There was a problem hiding this comment.
- works and looks good, thanks for the pr
- nice to know: getContact() is not called within this lib -> no internal side effects
|
Thanks for providing a fix for that. Is there any expected timeframe when this will go into a new release? |
|
any news here? |
|
can we merge this ??? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's Encrypt no longer supports sending expiration notifications with contact info. This PR fixes the error.
Ref:
https://letsencrypt.org/2025/01/22/ending-expiration-emails/
https://community.letsencrypt.org/t/support-ended-for-expiration-notification-emails/238173