Added ability to retrieve more information on challenge validation failure#57
Open
adamzero1 wants to merge 3 commits intoafosto:masterfrom
Open
Added ability to retrieve more information on challenge validation failure#57adamzero1 wants to merge 3 commits intoafosto:masterfrom
adamzero1 wants to merge 3 commits intoafosto:masterfrom
Conversation
…tself Meaning the Client object doesn't need to know about all potential fields for the challenge object.
Added new variables to the challenge object Added a new Error object This way if a challenge fails to validate, information about why the validation failed can be obtained.
SyedMuradAliShah
approved these changes
Aug 20, 2023
Author
|
Is there something needed from me to get this merged in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: added docs for accessing validation error messages
refactor: refactored Client class to let challenge object construct itself
Meaning the Client object doesn't need to know about all potential fields for the challenge object.
feat: validation error message access
Added new variables to the challenge object
Added a new Error object
This way if a challenge fails to validate, information about why the validation failed can be obtained.