Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Update to Bevy 0.15#127

Open
NthTensor wants to merge 2 commits into
aevyrie:mainfrom
NthTensor:main
Open

Update to Bevy 0.15#127
NthTensor wants to merge 2 commits into
aevyrie:mainfrom
NthTensor:main

Conversation

@NthTensor

Copy link
Copy Markdown

Update to Bevy 0.15, see change-log for details.

@oh-wind

oh-wind commented Dec 10, 2024

Copy link
Copy Markdown

Tank you for your work.
I ran a test. but doesn't seem to work on my machine.

Environment:

SystemInfo {
    os: "Linux rolling Arch Linux",
    kernel: "6.12.1-arch1-1", 
    cpu: "AMD Ryzen 5 7500F 6-Core Processor", 
    core_count: "6", 
    memory: "31.1 GiB"
 }

ss_20241211_002348

@NthTensor

NthTensor commented Dec 10, 2024

Copy link
Copy Markdown
Author

I'll take a look when I get time. This code probably has not been as fully tested as it should.

Comment thread src/immediate.rs

#[cfg(feature = "2d")]
type MeshFilter = Or<(With<Handle<Mesh>>, With<bevy_sprite::Mesh2dHandle>)>;
type MeshFilter = With<Mesh2d>;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be type MeshFilter = Or<(With<Mesh3d>, With<Mesh2d>)>; not type MeshFilter = With<Mesh2d>;.
This excludes 3d meshes whenever the 2d feature is enabled.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the Raycasting ✅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants