Open
Conversation
Collaborator
Author
|
@SeppeDeWinter I merged this too quickly without enough testing. Will get back to this later, but it looks like OOM errors happens more quickly with this change (and still need to fix tensor shape issue) |
Collaborator
Author
|
Original merge reverted in #105 |
Collaborator
|
@LukasMahieu Thanks for looking into it. I was playing around some more with the code (some time ago) and realised it needed more extensive changes, for that reason I also did not merge it yet. I did not have time yet to get back to this. |
This was referenced Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix concat issue in merged tf explainer PR, see #84